Attached to Project: CRUX-ARM
Opened by Victor Martinez - 2013-09-15
Last edited by Victor Martinez - 2013-11-26

FS#56 - MAKEFLAGS should not fail if defined greater than 1 job

Review all our source tree so that if one tries to use MAKEFLAGS should not fail.

Right now would have to set those parts that need to be forced to -j1.

Project Manager
Jose V Beneyto commented on Thursday, 31 October 2013, 11:16 GMT

I'm agree with this feature but there are some differences from pkgutils and pkgmk.conf usage for MAKEFLAGS.
Since pkgmk is a shell script written in bash it requires a definition of MAKEFLAGS for the existing environment executed in bash, in other words you need to export MAKEFLAGS.
In our case, we are not in a shell script enviroment so we can use directly MAKEFLAGS.

For example, if I'm right, theorically you can compile initramfs.git with 'make MAKEFLAGS="-j2"' and that be used every time you call make.
I tried it and worked but not fully. This is due to some parts must require to be forced to '-j1', like 'make install' when build 'dialog'.
Also 'busybox' failed to compile if '-j1' is not forced to use.

So I think we can start to implement this feature but IMHO we don't need to 'replicate' the MAKEFLAGS variable for our source tree, we are not in a shell script environment as I said first, just we need to force the parts that require '-j1' and let users to export MAKEFLAGS as their needs, but that doesn't means we cannot add some documentation.

Project Manager
Jose V Beneyto commented on Thursday, 31 October 2013, 11:19 GMT

also I suggest to change the 'task category' for this ticket and also create a list of tickets related to this one where we should review the build process when using MAKEFLAGS

Project Manager
Jose V Beneyto commented on Thursday, 31 October 2013, 16:32 GMT

what do you think about to take this task as general involving all our source tree? in this case we should change 'task category', summary and description to fit the needs

as a side note I started with initramfs/initrd and worked fine, next step should be kernels and look for more candidates

Project Manager
Jose V Beneyto commented on Friday, 01 November 2013, 11:24 GMT

I changed all as I said

Project Manager
Jose V Beneyto commented on Friday, 01 November 2013, 11:26 GMT
Project Manager
Jose V Beneyto commented on Friday, 01 November 2013, 12:04 GMT

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing